-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist before releasing 22.11.0 #627
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I'll test the following on Win32:
|
Awesome! Afterwards I think we're good to go with the release :) |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Slight regression introduced, see #634 (comment) |
Fixed in #635 |
I got my virtual Windows 32-bit machine working too! Everything seems to work, except converting mp3 to mp4. That goes wrong every time. The error is now caught and a human friendly warning is given. Since converting mp3 to mp4 is a real edge case, and it only goes wrong on (low-memory?) 32-bit machines, I'd say forget about it. |
Even worse, it works for me in Win32 😆 |
Haha, then it's probably a memory thing. |
I'd say we're good to go then |
Will you do the honors, or me? |
It's easier for you, since you can push directly to master. I'd have to create a pull request which I'm not sure has the desired outcome. |
@sircharlo, so what happened is you wanted to push the release commit, but got blocked because you had to git pull first. Then when you pushed the merge commit got evaluated instead of the release commit, so no release workflow was executed. You'll have to do another chore(release) |
Yeah my bad, I redid it and it worked after. :) |
Weirdly enough, the autoupdate didn't work for me until I deleted the |
Hmm, it worked fine for me. The desktop shortcut also correctly updated this time. |
Did you have a locally generated version installed by chance? |
Nah, I didn't build on my machine at all. Must be a glitch with my setup, I wouldn't worry about it too much |
Some things that need to be tested again before releasing:
The text was updated successfully, but these errors were encountered: