Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist before releasing 22.11.0 #627

Closed
4 tasks done
mtdvlpr opened this issue Nov 6, 2022 · 45 comments
Closed
4 tasks done

Checklist before releasing 22.11.0 #627

mtdvlpr opened this issue Nov 6, 2022 · 45 comments
Assignees
Labels
implemented Taken care of by a new commit/version

Comments

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Nov 6, 2022

Some things that need to be tested again before releasing:

  • Malagasy works without dayjs error
  • Image zoom and pan works correctly and preview and media window always show the same (3399c9a)
  • Everything works correctly on Windows 32-bit platform (b92db40)
  • mp3 to mp4 conversion works correctly (412238b)
@sircharlo

This comment was marked as outdated.

@sircharlo

This comment was marked as outdated.

@sircharlo

This comment was marked as outdated.

@mtdvlpr

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@sircharlo
Copy link
Owner

sircharlo commented Nov 6, 2022

I'll test the following on Win32:

  • sync
  • cong sync
  • cong upload
  • cong delete
  • image convert of PDFs
  • MP4 convert of images and MP3s (MP3s not working)
  • media playback window
  • zoom/pan
  • background music

@mtdvlpr
Copy link
Collaborator Author

mtdvlpr commented Nov 6, 2022

I'll test the following on Win32:

Awesome! Afterwards I think we're good to go with the release :)
The Sentry issues that are still open can't be pinned down to a fix (yet), so I'll set them to resolved in next release.

@sircharlo

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@mtdvlpr

This comment was marked as resolved.

@sircharlo

This comment was marked as resolved.

@sircharlo
Copy link
Owner

Slight regression introduced, see #634 (comment)

@mtdvlpr
Copy link
Collaborator Author

mtdvlpr commented Nov 7, 2022

Slight regression introduced, see #634 (comment)

Fixed in #635

@mtdvlpr
Copy link
Collaborator Author

mtdvlpr commented Nov 7, 2022

I got my virtual Windows 32-bit machine working too! Everything seems to work, except converting mp3 to mp4. That goes wrong every time. The error is now caught and a human friendly warning is given. Since converting mp3 to mp4 is a real edge case, and it only goes wrong on (low-memory?) 32-bit machines, I'd say forget about it.

@sircharlo
Copy link
Owner

I got my virtual Windows 32-bit machine working too! Everything seems to work, except converting mp3 to mp4. That goes wrong every time. The error is now caught and a human friendly warning is given. Since converting mp3 to mp4 is a real edge case, and it only goes wrong on (low-memory?) 32-bit machines, I'd say forget about it.

Even worse, it works for me in Win32 😆
But agreed, not the end of the world.

@mtdvlpr
Copy link
Collaborator Author

mtdvlpr commented Nov 7, 2022

Haha, then it's probably a memory thing.

@mtdvlpr
Copy link
Collaborator Author

mtdvlpr commented Nov 7, 2022

I'd say we're good to go then

@sircharlo
Copy link
Owner

Will you do the honors, or me?

@mtdvlpr
Copy link
Collaborator Author

mtdvlpr commented Nov 7, 2022

It's easier for you, since you can push directly to master. I'd have to create a pull request which I'm not sure has the desired outcome.

@mtdvlpr
Copy link
Collaborator Author

mtdvlpr commented Nov 7, 2022

@sircharlo, so what happened is you wanted to push the release commit, but got blocked because you had to git pull first. Then when you pushed the merge commit got evaluated instead of the release commit, so no release workflow was executed. You'll have to do another chore(release)

@sircharlo
Copy link
Owner

@sircharlo, so what happened is you wanted to push the release commit, but got blocked because you had to git pull first. Then when you pushed the merge commit got evaluated instead of the release commit, so no release workflow was executed. You'll have to do another chore(release)

Yeah my bad, I redid it and it worked after. :)

@sircharlo
Copy link
Owner

Weirdly enough, the autoupdate didn't work for me until I deleted the %localappdata%\meeting-media-manager-updater folder.

@mtdvlpr
Copy link
Collaborator Author

mtdvlpr commented Nov 7, 2022

Hmm, it worked fine for me. The desktop shortcut also correctly updated this time.

@mtdvlpr
Copy link
Collaborator Author

mtdvlpr commented Nov 7, 2022

Did you have a locally generated version installed by chance?

@sircharlo
Copy link
Owner

Nah, I didn't build on my machine at all. Must be a glitch with my setup, I wouldn't worry about it too much

@mtdvlpr mtdvlpr closed this as completed Nov 7, 2022
@mtdvlpr mtdvlpr added the implemented Taken care of by a new commit/version label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implemented Taken care of by a new commit/version
Projects
None yet
Development

No branches or pull requests

2 participants