Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SirenExchange contract, allowing users to purchase options with any ERC20 token #61

Open
zareth-san opened this issue Aug 13, 2021 · 1 comment
Assignees

Comments

@zareth-san
Copy link
Contributor

See #60 for the design of the contract interface.

In addition to the contract we will need

Solidity tests for SirenExchange
add a deploy script and verify it on Polygon
@MysticDakra MysticDakra self-assigned this Aug 13, 2021
@zareth-san
Copy link
Contributor Author

In addition to the design up above, we should add Ethereum-specific functions for buying/selling with ETH. The logic will be almost identical, except the functions should be marked as payable, and instead of sending or receiving an ERC20 token, they will send or receive ETH.

You can use the Solidity code:

someAddress.transfer(amountInWei)

to transfer ETH from the SirenExchange to the msg.sender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants