Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SeriesName to use "-" instead of "." and add in the ability to have decimals instead of only whole numbers on SeriesNames #85

Open
MysticDakra opened this issue Sep 30, 2021 · 0 comments

Comments

@MysticDakra
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The problem we want to fix is the confusion where we have a series name like "WMATIC.USDC.20210827.C.1.WMATIC"

The issue is the strike price of mattic is "1.6" making the series name confusing since we can have multiple series with the same name.

Describe the solution you'd like

Change "WMATIC.USDC.20210827.C.1.WMATIC" to a more descriptive name like "WMATIC-USDC-20210827-C-1.6-WMATIC"
This would make it so we can include the decimal strike price of the series name.

Describe alternatives you've considered

We can leave it as it is because we dont rely on the series name for displaying data however I think it would be useful for when we query the graph so we dont need to call multiple properties to be able to differentiate between them.

Additional context

The screen show below shows what the subgraph returns without any other context except for series name showing why it may be confusing since we have multiple seriesnames with the same value.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant