Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output HTML Checkbox #11

Open
KyleKing opened this issue Dec 19, 2024 · 1 comment · May be fixed by #12
Open

Output HTML Checkbox #11

KyleKing opened this issue Dec 19, 2024 · 1 comment · May be fixed by #12

Comments

@KyleKing
Copy link

For consistency with the .js implementation (jgm/djot.js#102), it would be nice to output the HTML standard for input type=checkbox rather than the li with classes (https://github.com/sivukhin/godjot/blob/975b00d3ec5862ca6165c33272bb1bc2c1be8b9b/djot_parser/examples/todo-list.html)

I'm happy to submit a PR if this seems like a beneficial change. I'm not sure how changes are reflected across djot rendering implementations normally and this could be a breaking change for end users
@sivukhin
Copy link
Owner

Hi @KyleKing!

I think this is a good change and it should affect only rendering layer (see djot_html.go/DefaultConversionRegistry) which is exposed in godjot and can be redefined by user.

As godjot do not have a lot of users (I am actually not aware of any) - I think this change will be pretty safe and should not affect any users :)

So, feel free to open a PR!

@sivukhin sivukhin linked a pull request Dec 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#11): include input checkbox for task lists KyleKing/godjot
2 participants
@sivukhin @KyleKing