-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflicts when parsing tables #4
Comments
Hi, thanks for the bug report! I will look into the issue. I know that tables were tricky, which is why I added a test table to one of the test pages (source/rendered). My guess is, that my table detection logic does not recognize your table header row:
Sadly I can not rely on a set maximum length, since you can define badges like this one:
Personally I always use at least three dashes and have not yet needed to the alignment settings (like |
The problem was the single dash. I was under the assumption, that three or more dashes were needed for every field in the row between table header and body. The regex has been adjusted, and your problematic table now works for me (see latest tests). Can you please update the plugin to version 0.4.2 and tell me if you have any more broken tables? By the way: By adding |
Seems to work, thanks for the quick fix! |
Hi,
I use badges and tables in my documentation:
When the site builds, the above results in the following warnings:
Is there any way to make parsing more robust, and avoid producing those false negatives?
Note that the same warnings show up when the table has more than 3 columns, which is an easier case to handle in my opinion.
Further: handling badges in tables.
Thanks!
The text was updated successfully, but these errors were encountered: