Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backgroundImageStyle utility sanitize and slugify #46

Closed
AdrianFiroiu opened this issue Jun 17, 2021 · 0 comments · Fixed by #57
Closed

backgroundImageStyle utility sanitize and slugify #46

AdrianFiroiu opened this issue Jun 17, 2021 · 0 comments · Fixed by #57
Assignees
@mahdiyazdani
Labels
bug Something isn't working

Comments

@AdrianFiroiu
Copy link
Member

As @gooklani mentioned in PR #34, we should consider sanitizing and slugifying the URL that is passed to this utility function, in light of one of the test cases originally highlighted there (containing a space in the URL):

		[
			'https:// interactive-examples.mdn.mozilla.net/media/examples/lizard.png',
			{ backgroundImage: 'url(https:// interactive-examples.mdn.mozilla.net/media/examples/lizard.png)' },
		],

@kuserich @mahdiyazdani
@AdrianFiroiu AdrianFiroiu added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 17, 2021
@AdrianFiroiu AdrianFiroiu changed the title backgroundImageStyle utility enhancement backgroundImageStyle utility possible bug Jun 17, 2021
@AdrianFiroiu AdrianFiroiu changed the title backgroundImageStyle utility possible bug backgroundImageStyle utility sanitize and slugify Jun 17, 2021
@kuserich kuserich mentioned this issue Jun 23, 2021
Merged
@mahdiyazdani mahdiyazdani mentioned this issue Jun 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahdiyazdani mahdiyazdani

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate background-image URL argument sixach/wp-block-utils
2 participants
@mahdiyazdani @AdrianFiroiu