Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InsertAtIndex insert Arrays #79

Open
kuserich opened this issue Jul 8, 2021 · 0 comments
Open

InsertAtIndex insert Arrays #79

kuserich opened this issue Jul 8, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@kuserich
Copy link
Contributor

kuserich commented Jul 8, 2021

When given an array to insert, insertAtIndex adds the items of the array rather than the array.

Example:

const anArray = [ 'a', 'b', 'c' ];
const input = [ 'x' ];

insertAtIndex( anArray, input );

// => returns [ 'a', 'b', 'c', 'x' ]

I believe that this is a bug and that the result should be [ 'a', 'b', 'c', [ 'x' ].

This will be particularly relevant in case that the input array is an array of arrays such that the value to be added is in fact an array and should be added as an array.

This issue was initially raised in #69 (discussion).

@kuserich kuserich added the bug Something isn't working label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant