Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to use parsedown-highlight with parsedown-extra #9

Closed
Arteneko opened this issue May 19, 2020 · 5 comments · Fixed by #10
Closed

Add possibility to use parsedown-highlight with parsedown-extra #9

Arteneko opened this issue May 19, 2020 · 5 comments · Fixed by #10
Assignees
@sixlive

Comments

@Arteneko
Copy link

As title suggests. By design, parsedown's extensions are made by inheritance, which means that since you inherit Parsedown, parsedown-extra cannot be used.
@sixlive sixlive mentioned this issue May 20, 2020
Merged
@sixlive
Copy link
Owner

sixlive commented May 20, 2020

Does this address your needs? #10

@sixlive sixlive self-assigned this May 20, 2020
@Arteneko
Copy link
Author

That should, indeed, do the trick.

@sixlive
Copy link
Owner

sixlive commented May 20, 2020

I really wish it had a plugin system, operating on inheritance is a drag.

@Arteneko
Copy link
Author

Indeed, that's a shame. Parsedown would require a major version to be able to break free from historical code and provide a newer, cleaner API

@sixlive
Copy link
Owner

sixlive commented May 20, 2020

Yup. Tagged in v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sixlive sixlive

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds support for parsedown extra sixlive/parsedown-highlight
2 participants
@sixlive @Arteneko