Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkBubbleMenu not displayed if your Editor is inside a MUI Dialog modal #265

Closed
alaa-paramount opened this issue Aug 28, 2024 · 4 comments · Fixed by #291
Closed

LinkBubbleMenu not displayed if your Editor is inside a MUI Dialog modal #265

alaa-paramount opened this issue Aug 28, 2024 · 4 comments · Fixed by #291

Comments

@alaa-paramount
Copy link

Is your feature request related to a problem? Please describe.

LinkBubbleMenu is using MuiPopper wrapper, the problem is with the zIndex value between 3-4 by default (bug?)

Describe the solution you'd like

My expectation is to see the Link bubble menu from anyway, even when executing it inside a Dialog modal (but we see nothing on click)

Describe alternatives you've considered

My temp solution is to add this code to my createTheme to make it work:
createTheme({
MuiPopper: {
styleOverrides: {
root: {
// a fix for the tiptap links inside a modal
zIndex: "1300 !important"
}
}
}
})

@mohanlokesh
Copy link

mohanlokesh commented Sep 16, 2024

I am also facing this issue in my MUI drawer, I have used like this in createTheme as alternative.

MuiPopper: {
        styleOverrides: {
          root: {
            '&.MuiTiptap-ControlledBubbleMenu-root': {
              zIndex: 'var(--mui-zIndex-drawer)'
            },
            '&.MuiPopper-root[class*="ColorPickerPopper-root"]': {
              zIndex: 'var(--mui-zIndex-drawer)'
            }
          }
        }

@sjdemartini
Copy link
Owner

There is another approach that's been discussed before here to avoid this problem #206 (comment)

But I'll look into changing the default zIndex style too.

@sjdemartini
Copy link
Owner

I've updated the default z-index of the bubble menus and poppers to use theme.zIndex.tooltip to fix this problem, released in v1.14.0.

@alaa-paramount
Copy link
Author

@sjdemartini Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants