Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3 admin incompatibility with previous contracts #1038

Open
OleksanderSalamatov opened this issue Jan 26, 2024 · 0 comments
Open

2.3 admin incompatibility with previous contracts #1038

OleksanderSalamatov opened this issue Jan 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working known issue

Comments

@OleksanderSalamatov
Copy link

During testing of Release 2.3 we found that if we have change IP function called before updating admin, after update we will have error in admin related to 'getLastChangeIpTime' was not found in this contract's abi. This was done before skale-manager contracts update to 1.10.0-beta.0. Skaled containers is not starting during this error.

Admin should have fallback mechanism to use old algorithm of dealing with change IP procedure.

Versions:
admin: 2.6.0-beta.0
skale-manager: 1.9.4-stable.0

Short log:

'getLastChangeIpTime' was not found in this contract's abi.", ' Are you sure you provided the correct contract abi?')
Traceback (most recent call last):
  File "/usr/src/admin/core/schains/task.py", line 24, in run
    self.action()
  File "/usr/src/admin/core/schains/monitor/main.py", line 81, in run_config_pipeline
    current_nodes = get_current_nodes(skale, name)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/admin/core/node.py", line 387, in get_current_nodes
    node['ip_change_ts'] = skale.nodes.get_last_change_ip_time(node['id'])
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/skale/contracts/manager/nodes.py", line 140, in get_last_change_ip_time
    return self.contract.functions.getLastChangeIpTime(node_id).call()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/web3/contract/contract.py", line 419, in __getattr__
    raise ABIFunctionNotFound(
web3.exceptions.ABIFunctionNotFound: ("The function 'getLastChangeIpTime' was not found in this contract's abi.", ' Are you sure you provided the correct contract abi?')

Detailed log

@OleksanderSalamatov OleksanderSalamatov added the bug Something isn't working label Jan 26, 2024
@PolinaKiporenko PolinaKiporenko modified the milestone: SKALE 2.3 Jan 26, 2024
@PolinaKiporenko PolinaKiporenko modified the milestones: SKALE 2.3, SKALE 2.5 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working known issue
Projects
Status: To Do
Development

No branches or pull requests

4 participants