Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit validator node removal #501

Open
lukanus opened this issue Jan 19, 2021 · 1 comment
Open

Implicit validator node removal #501

lukanus opened this issue Jan 19, 2021 · 1 comment

Comments

@lukanus
Copy link

lukanus commented Jan 19, 2021

Hello
Thanks to eesmerdag investigation, we've discovered a scenario where it seems possible to remove node from validator that is not triggering unlink event.
There is external function deleteNodeForValidator that may be called out of the context. Inside it is calling removeNodeAddress. This path removes the node but doesn't effect in calling NodeAddressWasRemoved, so indexer won't be able to pick up this change.

┆Issue is synchronized with this Jira Task

@gannakulikova
Copy link
Contributor

Hi @lukanus, thank you very much for the contribution!
We will review the details and will keep you posted with the updates :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants