Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean warnings in skaled build #1508

Closed
kladkogex opened this issue Apr 29, 2023 · 2 comments · Fixed by #1516
Closed

Clean warnings in skaled build #1508

kladkogex opened this issue Apr 29, 2023 · 2 comments · Fixed by #1516
Assignees
@sergiy-skalelabs
Labels
release:2.2 Technical debt
Milestone
2.2

Comments

@kladkogex
Copy link
Collaborator

kladkogex commented Apr 29, 2023 •
edited
Loading

Describe the bug

Currently skaled build has lots of warnings

Some of them come from libbls (Oleh has a separate bug for it). There are also two warnings in consensus - Stan will address them

As part of code quality OKRs, release 2.2 has no warnings

To Reproduce

Build skaled

Expected behavior
Skaled build should have no warnings

Please disable warning either:

  • using cmake flags
  • or, if you want to disable them in a single file please use

push pragma as described here

https://www.fluentcpp.com/2019/08/30/how-to-disable-a-warning-in-cpp/#:~:text=To%20disable%20a%20set%20of,pop%E2%80%9D%20pre%2Dprocessor%20instruction.
@DmytroNazarenko DmytroNazarenko moved this to In Progress in SKALE Engineering 🚀 May 4, 2023
@sergiy-skalelabs sergiy-skalelabs linked a pull request May 4, 2023 that will close this issue
ticket-1508 skaled build is cleaned from all the possible warnings #1516
Merged
@sergiy-skalelabs sergiy-skalelabs added this to the 2.2 milestone May 15, 2023
@sergiy-skalelabs sergiy-skalelabs moved this from In Progress to Code Review in SKALE Engineering 🚀 May 15, 2023
@DmytroNazarenko DmytroNazarenko moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 May 15, 2023
@DmytroNazarenko DmytroNazarenko mentioned this issue Jun 20, 2023
Merged
@oleksandrSydorenkoJ
Copy link

Not for QA

@DmytroNazarenko
Copy link
Collaborator

skaled: 3.17.0-beta.1

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jun 21, 2023
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jun 21, 2023
@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergiy-skalelabs sergiy-skalelabs

Labels
release:2.2 Technical debt
Projects
SKALE Engineering 🚀
Archived in project
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

ticket-1508 skaled build is cleaned from all the possible warnings skalenetwork/skaled
4 participants
@kladkogex @DmytroNazarenko @sergiy-skalelabs @oleksandrSydorenkoJ