Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn signature is not displayed via json-rpc api #1529

Closed
olehnikolaiev opened this issue May 22, 2023 · 2 comments · Fixed by #1534
Closed

txn signature is not displayed via json-rpc api #1529

olehnikolaiev opened this issue May 22, 2023 · 2 comments · Fixed by #1534
Assignees
Labels
bug Something isn't working release:2.2

Comments

@olehnikolaiev
Copy link
Contributor

skaled does not treturn txn signature for some of json-rpc api calls, while ethreum mainnet does

https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_gettransactionbyhash

Json::Value toJson( dev::eth::LocalisedTransaction const& _t ) {
    Json::Value res;
    if ( _t ) {
        res["hash"] = toJS( _t.sha3() );
        res["input"] = toJS( _t.data() );
        res["to"] = _t.isCreation() ? Json::Value() : toJS( _t.receiveAddress() );
        res["from"] = toJS( _t.safeSender() );
        res["gas"] = toJS( _t.gas() );
        res["gasPrice"] = toJS( _t.gasPrice() );
        res["nonce"] = toJS( _t.nonce() );
        res["value"] = toJS( _t.value() );
        res["blockHash"] = toJS( _t.blockHash() );
        res["transactionIndex"] = toJS( _t.transactionIndex() );
        res["blockNumber"] = toJS( _t.blockNumber() );
    }
    return res;
}
@olehnikolaiev olehnikolaiev self-assigned this May 22, 2023
@DmytroNazarenko DmytroNazarenko added the bug Something isn't working label May 22, 2023
@DmytroNazarenko DmytroNazarenko moved this to Ready For Pickup in SKALE Engineering 🚀 May 23, 2023
@olehnikolaiev olehnikolaiev moved this from Ready For Pickup to In Progress in SKALE Engineering 🚀 May 30, 2023
@olehnikolaiev olehnikolaiev linked a pull request May 30, 2023 that will close this issue
@olehnikolaiev olehnikolaiev moved this from In Progress to Code Review in SKALE Engineering 🚀 May 31, 2023
@olehnikolaiev olehnikolaiev moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Jun 6, 2023
@DmytroNazarenko
Copy link
Collaborator

skaled: 3.17.0-beta.1

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jun 21, 2023
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jun 21, 2023
@oleksandrSydorenkoJ
Copy link

Verified on Regression network

skaled: 3.17.0-beta.7

curl -X POST --data '{ "jsonrpc": "2.0", "method": "eth_getTransactionByHash", "params": ["0x0e1bcb22758900067a65f6f2d37ca1702313d3e0b871adff43f9231dc71cc908"], "id": 73 }'  http://1.1.1.1:10259
{"id":73,"jsonrpc":"2.0","result":{"blockHash":"0x33973c1cae1a530407223800cda0344e6c5add9aaba4ee7099f4d701408dcf8e",
"blockNumber":"0xcccd",
"from":"0x741ab23dc395fbf94cabc7ef43718a9772723669",
"gas":"0x30d40",
"gasPrice":"0x186a0",
"hash":"0x0e1bcb22758900067a65f6f2d37ca1702313d3e0b871adff43f9231dc71cc908",
"input":"0x....123",
"nonce":"0x332f",
"r":"0x4e1a1a97a142594123b679deb26dbefc82e4c02c73b341627dd8fb1835e3adf4",
"s":"0x75c46491fe850aae1024764395e21cbe80342c977378f8b9b9558d441e5f3205",
"to":"0x7b57e552838cc414b4cebd287b3a31fdd4b9b3a1",
"transactionIndex":"0xc",
"v":"0xa2a0f1db",
"value":"0x0"}}

skaled: 3.16.1

 curl -X POST --data '{ "jsonrpc": "2.0", "method": "eth_getTransactionByHash", "params": ["0x2711ce040964c012d332544670654323d5b2f924e50941f71093636a19c400e8"], "id": 73 }'  https://staging-v3.skalenodes.com/v1/staging-legal-crazy-castor
{"id":73,"jsonrpc":"2.0","result":{"blockHash":"0x187aa0f3ca3316c6977591845a9d9e1ee54d17e082678ebdb23f2088a3e21519",
"blockNumber":"0x25033e",
"from":"0xc68acc784227dbeae98bb6f5ac3c57cce1ae9b4b",
"gas":"0x6c979",
"gasPrice":"0x186a0",
"hash":"0x2711ce040964c012d332544670654323d5b2f924e50941f71093636a19c400e8",
"input":"0x.123",
"nonce":"0x3c17",
"to":"0xfeb70e7ad36b425b698184b3d5b1f856c8132a42",
"transactionIndex":"0x0",
"value":"0x0"}}

@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release:2.2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants