Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with running under Webpack #127

Closed
acnebs opened this issue Jun 11, 2020 · 2 comments
Closed

Issues with running under Webpack #127

acnebs opened this issue Jun 11, 2020 · 2 comments

Comments

@acnebs
Copy link

acnebs commented Jun 11, 2020

Hi, I'm trying to run this under webpack, but dagre throws an error when I require nomnoml. To be specific, I have a React app created with create-react-app, that breaks when I try to use nomnoml inside of it.

It's an issue when dagre tries to import graphlib, wherein graphlib cannot be found, due to some sort of dependency-finding issue.

Is nobody else using nomnoml under Webpack? There don't seem to be any straightforward solutions to this problem, but there are various issues that people have had – just don't see how anyone else has actually fixed the problem.

Associated issues:
dagrejs/dagre-d3#129
mermaid-js/mermaid#277

@skanaar
Copy link
Owner

skanaar commented Jul 8, 2020

As you say, this seems to be an issue with Dagre. They have a workaround posted, but the best thing would be for these things to just work out of the box. Not sure if nomnoml can do anything to alleviate the problem however...

@skanaar
Copy link
Owner

skanaar commented Nov 4, 2020

This should now be solved in version v1.3.0. 🎉

Please try it out and report any issues.

@skanaar skanaar closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants