Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Generator Overhaul #269

Closed
endigo9740 opened this issue Sep 22, 2022 · 4 comments · Fixed by #278
Closed

Theme Generator Overhaul #269

endigo9740 opened this issue Sep 22, 2022 · 4 comments · Fixed by #278
Assignees
@endigo9740
Labels
documentation Improvements or additions to documentation enhancement New feature or request ready to test Ready to be tested for quality assurance.

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Sep 22, 2022 •
edited
Loading

Lots to do here:

  • Nuke it from orbit and start over.
  • Merge the two components into one.
  • Clean everything up.
  • Add support for "lightness" feature
  • Move to a dedicate page w/ kitchen sink of preview components
  • Prep for theme picker support
@endigo9740 endigo9740 self-assigned this Sep 22, 2022
@endigo9740 endigo9740 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 22, 2022
@endigo9740 endigo9740 mentioned this issue Sep 22, 2022
Closed
@endigo9740
Copy link
Contributor Author

endigo9740 commented Sep 22, 2022 •
edited
Loading

First draft of the new generator is ready. This moves the generator from the main Themes page to its own subpage, which is a lot easier to look at.

Screen Shot 2022-09-22 at 5 04 13 PM

this allows us more room for the generator UI, which means bigger swatches, etc. I've combined the two generators into one mega-generator component and cleaned up the code quite a lot.

Screen Shot 2022-09-22 at 5 03 26 PM

This also allows us to do more with the generated CSS. The new version includes the original hex color used to generate the RGB value for quick reference.

Screen Shot 2022-09-22 at 5 03 34 PM

I've also added a smooth color transition as the color values change.

themer-color-transitions

@endigo9740 endigo9740 pinned this issue Sep 23, 2022
@endigo9740 endigo9740 linked a pull request Sep 23, 2022 that will close this issue
Theme Generator Overhaul #278
Merged
@endigo9740
Copy link
Contributor Author

New draft PR available for anyone that wants to test this:
#278

Cleaned up the code and added a ternary color slots. Live preview is also functional, but doesn't persist the values if you leave the page.

@endigo9740 endigo9740 added the ready to test Ready to be tested for quality assurance. label Sep 24, 2022
@endigo9740
Copy link
Contributor Author

See also:

@endigo9740
Copy link
Contributor Author

Cherry pick the Local Storage Store via:

git cherry-pick af61660b3776623884f4ca41b342fb9b01101218

@endigo9740 endigo9740 mentioned this issue Sep 26, 2022
Closed
@endigo9740 endigo9740 unpinned this issue Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@endigo9740 endigo9740

Labels
documentation Improvements or additions to documentation enhancement New feature or request ready to test Ready to be tested for quality assurance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Theme Generator Overhaul skeletonlabs/skeleton
1 participant
@endigo9740