Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT: Resolve regressions in the component unit tests #2805

Closed
endigo9740 opened this issue Aug 13, 2024 · 2 comments · Fixed by #2814
Closed

NEXT: Resolve regressions in the component unit tests #2805

endigo9740 opened this issue Aug 13, 2024 · 2 comments · Fixed by #2814
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Aug 13, 2024

Following the recent integration of Zag, this introduced a number of changes that broken a various React component unit tests. We should make it a priority to restore these asap.

Goals

  1. Ensure we're only testing Skeleton-provided features. Zag is responsible for testing their features.
  2. We should prune all invalid test cases that do not confirm to the goal above.
  3. We should ensure all remaining tests are back in a working state.
  4. If possible we should aim to improve our test quality and coverage while we're at it.
  5. Provide test cases for components currently lacking a test spec

Progress:

NOTE: AppBar and Navigation do not implement Zag but still need test cases.

Component Status Owner
Accordion Hugo
AppBar* Hugo
Avatar Hugo
Navigation* Hugo
Progress Hugo
Progress Ring Chris
Rating Chris
Seg. Control Chris
Switch Chris
Tabs Chris
@endigo9740 endigo9740 added the enhancement New feature or request label Aug 13, 2024
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Aug 13, 2024
@endigo9740
Copy link
Contributor Author

endigo9740 commented Aug 13, 2024

@Hugos68 given the number of components I'm open to divvy this up in some manner. We should prioritize this above any other tasks. I wouldn't be opposed to revisit testing for Svelte components again either.

@endigo9740 endigo9740 pinned this issue Aug 13, 2024
@endigo9740 endigo9740 changed the title NEXT: Resolve and restore regression in the component unit tests NEXT: Resolve regressions in the component unit tests Aug 13, 2024
@endigo9740 endigo9740 linked a pull request Aug 14, 2024 that will close this issue
8 tasks
@endigo9740
Copy link
Contributor Author

@endigo9740 endigo9740 unpinned this issue Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants