You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following the recent integration of Zag, this introduced a number of changes that broken a various React component unit tests. We should make it a priority to restore these asap.
Goals
Ensure we're only testing Skeleton-provided features. Zag is responsible for testing their features.
We should prune all invalid test cases that do not confirm to the goal above.
We should ensure all remaining tests are back in a working state.
If possible we should aim to improve our test quality and coverage while we're at it.
Provide test cases for components currently lacking a test spec
Progress:
NOTE: AppBar and Navigation do not implement Zag but still need test cases.
Component
Status
Owner
Accordion
✅
Hugo
AppBar*
✅
Hugo
Avatar
✅
Hugo
Navigation*
✅
Hugo
Progress
✅
Hugo
Progress Ring
✅
Chris
Rating
✅
Chris
Seg. Control
✅
Chris
Switch
✅
Chris
Tabs
✅
Chris
The text was updated successfully, but these errors were encountered:
@Hugos68 given the number of components I'm open to divvy this up in some manner. We should prioritize this above any other tasks. I wouldn't be opposed to revisit testing for Svelte components again either.
endigo9740
changed the title
NEXT: Resolve and restore regression in the component unit tests
NEXT: Resolve regressions in the component unit tests
Aug 13, 2024
Following the recent integration of Zag, this introduced a number of changes that broken a various React component unit tests. We should make it a priority to restore these asap.
Goals
Progress:
The text was updated successfully, but these errors were encountered: