Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Generator Shiki Component Improvements #2864

Open
endigo9740 opened this issue Sep 27, 2024 · 1 comment
Open

Theme Generator Shiki Component Improvements #2864

endigo9740 opened this issue Sep 27, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Sep 27, 2024

We've currently implemented a code block for the new Theme Generator using Shiki. I've modeled this after the integration from the Floating UI Svelte app. However, Shiki has updated to use a Singleton approach. So we should update at least the Theme Generator implementation, which can be found in /lib/components/common/CodeBlock/CodeBlock.svelte

This will be used as the basis for the upcoming integration guide, so any other improvements are welcome:

Likewise, I wouldn't mind if the Floating UI Svelte version was updated alongside this. But it's lesser priority.

@endigo9740 endigo9740 added the enhancement New feature or request label Sep 27, 2024
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Sep 27, 2024
@endigo9740
Copy link
Contributor Author

This should now adhere to the simpler implementation documented in our Integration Guide:

https://next.skeleton.dev/docs/integrations/code-block/svelte

Any reference to Shiki in the SvelteKit hooks, etc can be removed. Everything should be contained specifically within our dedicated component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants