Utilizes ApiErrorResponse<U> in all of the HTTP methods #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rszalski! We had another PR merged yesterday which fixed the same linter issues, so there are some conflicts now. If you get those fixed up, we can merge this! |
|
@robinheinze done! Should be all good now :) |
infinitered-circleci
pushed a commit
that referenced
this pull request
Sep 17, 2019
## [1.1.1](v1.1.0...v1.1.1) (2019-09-17) ### Bug Fixes * **ts-params:** Utilizes ApiErrorResponse<U> in all of the HTTP methods ([#228](#228)) ([94dedd7](94dedd7))
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is a follow up to #219, which introduced a second type parameter used when the error response has a different structure. However, when adding types to actual API calls (HTTP methods) I noticed that this ApiErrorResponse type is not utilized.
This PR fixes it by adding a second parameter
U = Tto all HTTP method calls.All the remaining changes are style fixes introduced by linter commit hook.