Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override of User-Agent header? #62

Closed
rmosolgo opened this issue May 30, 2017 · 2 comments · Fixed by #115
Closed

Allow override of User-Agent header? #62

rmosolgo opened this issue May 30, 2017 · 2 comments · Fixed by #115
Labels
enhancement

Comments

@rmosolgo
Copy link

Hey, thanks for the great app! It's been really really useful.

I'm in an interesting spot now -- I'm trying to test an API whose behavior depends on the incoming User-Agent header.

I tried setting it in the headers box, but it looks like it wasn't applied:

image

image

Would it be possible to accept user-agent overrides here? Thanks!
@skevy
Copy link
Owner

skevy commented Jun 17, 2017 •
edited
Loading

Sure. Want to send a PR?

@intellix
Copy link
Contributor

#66 adds support for Origin header to get around CORS and you can also send the User-Agent header there too. If you provide it with fetch then it won't get sent at all.

I'm guessing some stuff needs refactoring to send requests via Electron instead of Fetch

@craig-day craig-day mentioned this issue Mar 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to ClientRequest so we have better control craig-day/graphiql-app
3 participants
@skevy @intellix @rmosolgo