Version 2.19.0-377.0.dev

Merge 6a249fd into dev

Author: Dart CI

CHANGELOG.md

@@ -161,8 +161,48 @@
 
 #### Linter
 
-Updated the Linter to `1.28.0`, which includes changes that
-
+Updated the Linter to `1.29.0`, which includes changes that
+
+- add new lint: `dangling_library_doc_comments`.
+- fix `no_leading_underscores_for_local_identifiers` to not report super formals
+  as local variables.
+- fix `unnecessary_overrides` false negatives.
+- fix `cancel_subscriptions` for nullable fields.
+- add new lint: `collection_methods_unrelated_type`.
+- update `library_names` to support unnamed libraries.
+- fix `unnecessary_parenthesis` support for as-expressions.
+- fix `use_build_context_synchronously` to check for context property accesses.
+- fix false positive in `comment_references`.
+- improved unrelated type checks to handle enums and cascades.
+- fix `unnecessary_brace_in_string_interps` for `this` expressions .
+- update `use_build_context_synchronously` for `BuildContext.mounted`.
+- improve `flutter_style_todos` to handle more cases.
+- fix `use_build_context_synchronously` to check for `BuildContext`s in named
+  expressions.
+- fix `exhaustive_cases` to check parenthesized expressions
+- improves performance for:
+  - `avoid_null_checks_in_equality_operators`.
+  - `join_return_with_statement`.
+  - `recursive_getters`.
+  - `unnecessary_lambdas`.
+  - `diagnostic_describe_all_properties`.
+  - `prefer_foreach`.
+  - `avoid_escaping_inner_quotes`.
+  - `cascade_invocations`.
+  - `tighten_type_of_initializing_formals`.
+  - `prefer_interpolation_to_compose_strings`.
+  - `prefer_constructors_over_static_methods`.
+  - `avoid_returning_null`.
+  - `parameter_assignments`.
+  - `prefer_constructors_over_static_methods`.
+  - `prefer_interpolation_to_compose_strings`.
+  - `avoid_returning_null`.
+  - `avoid_returning_this`.
+  - `flutter_style_todos`.
+  - `avoid_positional_boolean_parameters`.
+  - `prefer_const_constructors`.
+- add new lint: `implicit_call_tearoffs`.
+- add new lint: `unnecessary_library_directive`.
 - update `avoid_redundant_argument_values` to work with enum declarations.
 - improve performance for `prefer_contains`.
 - add new lint: `unreachable_from_main`.

DEPS

@@ -136,7 +136,7 @@ vars = {
   "intl_rev": "442193ccd19a8e36a07fcc3b3cac0e58c6f9c542",
   "jinja2_rev": "2222b31554f03e62600cd7e383376a7c187967a1",
   "json_rpc_2_rev": "805e6536dd961d66f6b8cd46d8f3e61774f957c9",
-  "linter_rev": "f2c55484e8ebda0aec8c2fea637b3bd5b17258ca", # 1.28.0
+  "linter_rev": "657fa6d60373c144777ddb3ca0ab6ee7805ea2b3", # 1.29.0
   "lints_rev": "16bdefe1df529262a6596f79e91003ddbdbd3890",
   "logging_rev": "f322480fb9d9e83e677c08db6d09067059f7ff74",
   "markdown_rev": "9ff4a9f1d37c763f827084ba28a3d0bfec6b5d67",

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -5534,6 +5534,76 @@ const MessageCode messageImportAfterPart = const MessageCode("ImportAfterPart",
     correctionMessage:
         r"""Try moving the import directives before the part directives.""");
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<
+    Message Function(
+        Uri uri_,
+        String string,
+        String
+            string2)> templateImportChainContext = const Template<
+        Message Function(Uri uri_, String string, String string2)>(
+    problemMessageTemplate:
+        r"""The unavailable library '#uri' is imported through these packages:
+
+#string
+Detailed import paths for (some of) the these imports:
+
+#string2""",
+    withArguments: _withArgumentsImportChainContext);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Message Function(Uri uri_, String string, String string2)>
+    codeImportChainContext =
+    const Code<Message Function(Uri uri_, String string, String string2)>(
+        "ImportChainContext",
+        severity: Severity.context);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsImportChainContext(
+    Uri uri_, String string, String string2) {
+  String? uri = relativizeUri(uri_);
+  if (string.isEmpty) throw 'No string provided';
+  if (string2.isEmpty) throw 'No string provided';
+  return new Message(codeImportChainContext,
+      problemMessage:
+          """The unavailable library '${uri}' is imported through these packages:
+
+${string}
+Detailed import paths for (some of) the these imports:
+
+${string2}""",
+      arguments: {'uri': uri_, 'string': string, 'string2': string2});
+}
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<Message Function(Uri uri_, String string)>
+    templateImportChainContextSimple =
+    const Template<Message Function(Uri uri_, String string)>(
+        problemMessageTemplate:
+            r"""The unavailable library '#uri' is imported through these paths:
+
+#string""",
+        withArguments: _withArgumentsImportChainContextSimple);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Message Function(Uri uri_, String string)>
+    codeImportChainContextSimple =
+    const Code<Message Function(Uri uri_, String string)>(
+        "ImportChainContextSimple",
+        severity: Severity.context);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsImportChainContextSimple(Uri uri_, String string) {
+  String? uri = relativizeUri(uri_);
+  if (string.isEmpty) throw 'No string provided';
+  return new Message(codeImportChainContextSimple,
+      problemMessage:
+          """The unavailable library '${uri}' is imported through these paths:
+
+${string}""",
+      arguments: {'uri': uri_, 'string': string});
+}
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeIncorrectTypeArgumentVariable =
     messageIncorrectTypeArgumentVariable;
@@ -11517,6 +11587,27 @@ const MessageCode messageTypedefUnaliasedTypeCause = const MessageCode(
     severity: Severity.context,
     problemMessage: r"""This is the type denoted by the type alias.""");
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<Message Function(Uri uri_)> templateUnavailableDartLibrary =
+    const Template<Message Function(Uri uri_)>(
+        problemMessageTemplate:
+            r"""Dart library '#uri' is not available on this platform.""",
+        withArguments: _withArgumentsUnavailableDartLibrary);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Message Function(Uri uri_)> codeUnavailableDartLibrary =
+    const Code<Message Function(Uri uri_)>("UnavailableDartLibrary",
+        analyzerCodes: <String>["URI_DOES_NOT_EXIST"]);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsUnavailableDartLibrary(Uri uri_) {
+  String? uri = relativizeUri(uri_);
+  return new Message(codeUnavailableDartLibrary,
+      problemMessage:
+          """Dart library '${uri}' is not available on this platform.""",
+      arguments: {'uri': uri_});
+}
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeUnexpectedDollarInString = messageUnexpectedDollarInString;
 

pkg/_fe_analyzer_shared/lib/src/type_inference/type_analyzer.dart

@@ -572,6 +572,60 @@ mixin TypeAnalyzer<
     }
   }
 
+  /// Analyzes an object pattern.  [node] is the pattern itself, and [fields]
+  /// is the list of subpatterns.  The [requiredType] must be not `null` in
+  /// irrefutable contexts, but can be `null` in refutable contexts, then
+  /// [downwardInferObjectPatternRequiredType] is invoked to infer the type.
+  ///
+  /// See [dispatchPattern] for the meanings of [matchedType], [typeInfos], and
+  /// [context].
+  ///
+  /// Stack effect: pushes (n * Pattern) where n = fields.length.
+  Type analyzeObjectPattern(
+    Type matchedType,
+    Map<Variable, VariableTypeInfo<Pattern, Type>> typeInfos,
+    MatchContext<Node, Expression> context,
+    Pattern node, {
+    required Type? requiredType,
+    required List<RecordPatternField<Pattern>> fields,
+  }) {
+    requiredType ??= downwardInferObjectPatternRequiredType(
+      matchedType: matchedType,
+      pattern: node,
+    );
+
+    Node? irrefutableContext = context.irrefutableContext;
+    if (irrefutableContext != null &&
+        !typeOperations.isAssignableTo(matchedType, requiredType)) {
+      errors?.patternTypeMismatchInIrrefutableContext(
+        pattern: node,
+        context: irrefutableContext,
+        matchedType: matchedType,
+        requiredType: requiredType,
+      );
+    }
+
+    // Stack: ()
+    for (RecordPatternField<Pattern> field in fields) {
+      Type propertyType = resolveObjectPatternPropertyGet(
+        receiverType: requiredType,
+        field: field,
+      );
+      dispatchPattern(propertyType, typeInfos, context, field.pattern);
+    }
+    // Stack: (n * Pattern) where n = fields.length
+
+    return requiredType;
+  }
+
+  /// Computes the type schema for an object pattern.  [type] is the type
+  /// specified with the object name, and with the type arguments applied.
+  ///
+  /// Stack effect: none.
+  Type analyzeObjectPatternSchema(Type type) {
+    return type;
+  }
+
   /// Analyzes a record pattern.  [node] is the pattern itself, and [fields]
   /// is the list of subpatterns.
   ///
@@ -584,9 +638,9 @@ mixin TypeAnalyzer<
     Map<Variable, VariableTypeInfo<Pattern, Type>> typeInfos,
     MatchContext<Node, Expression> context,
     Pattern node, {
-    required List<RecordPatternField<Node>> fields,
+    required List<RecordPatternField<Pattern>> fields,
   }) {
-    void dispatchField(RecordPatternField<Node> field, Type matchedType) {
+    void dispatchField(RecordPatternField<Pattern> field, Type matchedType) {
       dispatchPattern(matchedType, typeInfos, context, field.pattern);
     }
 
@@ -599,7 +653,7 @@ mixin TypeAnalyzer<
     // Build the required type.
     int requiredTypePositionalCount = 0;
     List<NamedType<Type>> requiredTypeNamedTypes = [];
-    for (RecordPatternField<Node> field in fields) {
+    for (RecordPatternField<Pattern> field in fields) {
       String? name = field.name;
       if (name == null) {
         requiredTypePositionalCount++;
@@ -655,11 +709,11 @@ mixin TypeAnalyzer<
   ///
   /// Stack effect: none.
   Type analyzeRecordPatternSchema({
-    required List<RecordPatternField<Node>> fields,
+    required List<RecordPatternField<Pattern>> fields,
   }) {
     List<Type> positional = [];
     List<NamedType<Type>> named = [];
-    for (RecordPatternField<Node> field in fields) {
+    for (RecordPatternField<Pattern> field in fields) {
       Type fieldType = dispatchPatternSchema(field.pattern);
       String? name = field.name;
       if (name != null) {
@@ -1031,6 +1085,12 @@ mixin TypeAnalyzer<
   /// Stack effect: pushes (Statement).
   void dispatchStatement(Statement statement);
 
+  /// Infers the type for the [pattern], should be a subtype of [matchedType].
+  Type downwardInferObjectPatternRequiredType({
+    required Type matchedType,
+    required Pattern pattern,
+  });
+
   /// Called after visiting an expression case.
   ///
   /// [node] is the enclosing switch expression, and [caseIndex] is the index of
@@ -1155,6 +1215,14 @@ mixin TypeAnalyzer<
   /// Builds the client specific record type.
   Type recordType(RecordType<Type> type);
 
+  /// Returns the type of the property in [receiverType] that corresponds to
+  /// the name of the [field].  If the property cannot be resolved, the client
+  /// should report an error, and return `dynamic` for recovery.
+  Type resolveObjectPatternPropertyGet({
+    required Type receiverType,
+    required RecordPatternField<Pattern> field,
+  });
+
   /// Records that type inference has assigned a [type] to a [variable].  This
   /// is called once per variable, regardless of whether the variable's type is
   /// explicit or inferred.
@@ -1199,7 +1267,7 @@ mixin TypeAnalyzer<
   /// [matchedType], returns matched types for each field in [fields].
   /// Otherwise returns `null`.
   List<Type>? _matchRecordTypeShape(
-    List<RecordPatternField<Node>> fields,
+    List<RecordPatternField<Pattern>> fields,
     RecordType<Type> matchedType,
   ) {
     Map<String, Type> matchedTypeNamed = {};
@@ -1210,7 +1278,7 @@ mixin TypeAnalyzer<
     List<Type> result = [];
     int positionalIndex = 0;
     int namedCount = 0;
-    for (RecordPatternField<Node> field in fields) {
+    for (RecordPatternField<Pattern> field in fields) {
       Type? fieldType;
       String? name = field.name;
       if (name != null) {