Skip to content

Commit ea66251

Browse files
rmistrySkia Commit-Bot
authored andcommitted
Delete Android compile bots
Bug: skia:10553 Change-Id: I2fd1d5c309b88b0c9e3ce26392ede9fcd2aa6fba Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306853 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
1 parent da1abd1 commit ea66251

File tree

11 files changed

+4
-769
lines changed

11 files changed

+4
-769
lines changed

infra/bots/android_compile/trigger_wait_ac_task.py

Lines changed: 0 additions & 237 deletions
This file was deleted.

infra/bots/gen_tasks_logic/gen_tasks_logic.go

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -392,10 +392,7 @@ func (b *taskBuilder) kitchenTaskNoBundle(recipe string, outputDir string) {
392392
}
393393

394394
// Attempts.
395-
if b.extraConfig("Framework") && b.extraConfig("Android", "G3") {
396-
// Both bots can be long running. No need to retry them.
397-
b.attempts(1)
398-
} else if !b.role("Build", "Upload") && b.extraConfig("ASAN", "MSAN", "TSAN", "Valgrind") {
395+
if !b.role("Build", "Upload") && b.extraConfig("ASAN", "MSAN", "TSAN", "Valgrind") {
399396
// Sanitizers often find non-deterministic issues that retries would hide.
400397
b.attempts(1)
401398
} else {
@@ -1164,21 +1161,6 @@ func (b *jobBuilder) housekeeper() {
11641161
})
11651162
}
11661163

1167-
// androidFrameworkCompile generates an Android Framework Compile task. Returns
1168-
// the name of the last task in the generated chain of tasks, which the Job
1169-
// should add as a dependency.
1170-
func (b *jobBuilder) androidFrameworkCompile() {
1171-
b.addTask(b.Name, func(b *taskBuilder) {
1172-
b.recipeProps(EXTRA_PROPS)
1173-
b.kitchenTask("android_compile", OUTPUT_NONE)
1174-
b.isolate("compile_android_framework.isolate")
1175-
b.serviceAccount("skia-android-framework-compile@skia-swarming-bots.iam.gserviceaccount.com")
1176-
b.linuxGceDimensions(MACHINE_TYPE_SMALL)
1177-
b.timeout(2 * time.Hour)
1178-
b.usesGit()
1179-
})
1180-
}
1181-
11821164
// g3FrameworkCanary generates a G3 Framework Canary task. Returns
11831165
// the name of the last task in the generated chain of tasks, which the Job
11841166
// should add as a dependency.

infra/bots/gen_tasks_logic/job_builder.go

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,8 @@ func (b *jobBuilder) genTasksForJob() {
154154

155155
// Compile bots.
156156
if b.role("Build") {
157-
if b.extraConfig("Android") && b.extraConfig("Framework") {
158-
// Android Framework compile tasks use a different recipe.
159-
b.androidFrameworkCompile()
160-
return
161-
} else {
162-
b.compile()
163-
return
164-
}
157+
b.compile()
158+
return
165159
}
166160

167161
// BuildStats bots. This computes things like binary size.
@@ -228,7 +222,7 @@ func (b *jobBuilder) finish() {
228222
b.trigger(specs.TRIGGER_WEEKLY)
229223
} else if b.extraConfig("Flutter", "CommandBuffer") {
230224
b.trigger(specs.TRIGGER_MASTER_ONLY)
231-
} else if b.frequency("OnDemand") || (b.extraConfig("Framework") && b.extraConfig("Android", "G3") || b.role("Canary")) {
225+
} else if b.frequency("OnDemand") || b.role("Canary") {
232226
b.trigger(specs.TRIGGER_ON_DEMAND)
233227
} else {
234228
b.trigger(specs.TRIGGER_ANY_BRANCH)

infra/bots/jobs.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
"Build-Debian10-Clang-arm64-Release-Android",
2424
"Build-Debian10-Clang-arm64-Release-Android_Vulkan",
2525
"Build-Debian10-Clang-arm64-Release-Android_Wuffs",
26-
"Build-Debian10-Clang-cf_x86_phone-eng-Android_Framework",
27-
"Build-Debian10-Clang-host-sdk-Android_Framework",
2826
"Build-Debian10-Clang-x64-Debug-Android",
2927
"Build-Debian10-Clang-x64-Release-Android",
3028
"Build-Debian10-Clang-x86-Debug",

infra/bots/recipes/android_compile.expected/android_compile_nontrybot.json

Lines changed: 0 additions & 29 deletions
This file was deleted.

infra/bots/recipes/android_compile.expected/android_compile_sdk_trybot.json

Lines changed: 0 additions & 27 deletions
This file was deleted.

infra/bots/recipes/android_compile.expected/android_compile_trybot.json

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)