Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "Edit file" is grayed out in Step 1 #245

Open
hadder94 opened this issue Dec 9, 2024 · 3 comments
Open

[Bug] "Edit file" is grayed out in Step 1 #245

hadder94 opened this issue Dec 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@hadder94
Copy link

hadder94 commented Dec 9, 2024

Summary

In step 1 of the tutorial, the "Edit file" option for "index.md" file is grayed out when creating a PR.

How to reproduce

  1. Open the pull requests tab.
  2. Click New pull request, for the branches to compare, select base: main and compare: start-markdown.
  3. Click Create pull request.
  4. In this pull request, go to the Files changed tab. We made an empty file index.md for you.
  5. Select Edit file from the three dotted ... menu in the upper right corner of the file view on index.md.
Screenshot 2024-12-09 at 3 48 30 PM
@hadder94 hadder94 added the bug Something isn't working label Dec 9, 2024
@hadder94 hadder94 changed the title [Bug] "Edit file [Bug] "Edit file" is grayed out in Step 1 Dec 9, 2024
@sarnett24
Copy link

It turns out that you need to push the Pull Request once more for the edit functionality to show. https://github.com/orgs/skills/discussions/354
image

mjbear's comment is how I found it.

@nguyenalex836
Copy link

@hadder94 Thank you for raising the flag on this! I'll get this triaged for the team to review ✨

@aflacake
Copy link

After merge it, when committing the file index.md as per the step request (added headings). Workflow doesn't continue to next step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants