Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Change Affiliate Fee Logic To Be Based On Min Coin Within swap_and_action #38

Merged
merged 5 commits into from
Jul 31, 2023
Merged

✨ Change Affiliate Fee Logic To Be Based On Min Coin Within swap_and_action #38

merged 5 commits into from
Jul 31, 2023

Conversation

NotJeremyLiu
Copy link
Member

@NotJeremyLiu NotJeremyLiu commented Jul 28, 2023 •
edited
Loading

This PR:

  • Changes affiliate fee amount to be derived from the BPS applied to the min_coin (rather than the contract balance post-swap), allowing us to have a standardized affiliate fee calc for both SwapExactCoinIn and SwapExactCoinOut
  • Moves the affiliate fee logic into swap_and_action
  • Adds affiliate fee tests to swap_and_action tests
  • Removes affiliate fee tests from posts_swap_action tests

@NotJeremyLiu NotJeremyLiu changed the base branch from main to jl/change-user-swap-type-to-swap-enum July 28, 2023 21:17
This was referenced Jul 28, 2023
Closed
Closed
@NotJeremyLiu NotJeremyLiu force-pushed the jl/change-user-swap-type-to-swap-enum branch 2 times, most recently from 0290c64 to 0593bdd Compare July 28, 2023 23:46
@NotJeremyLiu NotJeremyLiu force-pushed the jl/change-affiliate-fee-to-be-based-on-min-coin branch 3 times, most recently from 7a2314b to 98aee7a Compare July 28, 2023 23:52
Base automatically changed from jl/change-user-swap-type-to-swap-enum to main July 31, 2023 06:57
@NotJeremyLiu NotJeremyLiu force-pushed the jl/change-affiliate-fee-to-be-based-on-min-coin branch from 98aee7a to ed97940 Compare July 31, 2023 06:58
@NotJeremyLiu NotJeremyLiu merged commit 86b02a8 into main Jul 31, 2023
@NotJeremyLiu NotJeremyLiu deleted the jl/change-affiliate-fee-to-be-based-on-min-coin branch July 31, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrbecker zrbecker zrbecker approved these changes

@wllmshao wllmshao Awaiting requested review from wllmshao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotJeremyLiu @zrbecker