Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor Fee Swap Into Ibc Transfer Variant of Action Enum #63

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

NotJeremyLiu
Copy link
Member

@NotJeremyLiu NotJeremyLiu commented Aug 9, 2023

Background

  • Previously, the contract would throw an error if a fee_swap was provided but the post swap action was not an ibc transfer/
  • This is unnecessary as the fee_swap option could instead be placed into the ibc transfer variant of the post swap action enum, enforcing this requirement via the types themselves.

This PR

  • Refactors fee_swap by moving it into the Action enum's IbcTransfer variant
  • Updates tests accordingly
  • Changes entry point logic slightly to use an if let pattern instead of matching on the post swap action enum (since we only match on 1 variant now)

@NotJeremyLiu NotJeremyLiu added the interface-breaking changes that break the user-facing interface to call the contract label Aug 9, 2023
This was referenced Aug 9, 2023
@NotJeremyLiu NotJeremyLiu force-pushed the jl/place-fee-swap-in-ibc-transfer-action-variant branch from a1b6ab6 to b561dea Compare August 9, 2023 19:18
@NotJeremyLiu NotJeremyLiu requested a review from wllmshao August 9, 2023 20:46
@NotJeremyLiu NotJeremyLiu force-pushed the jl/place-fee-swap-in-ibc-transfer-action-variant branch from 0dc32d8 to 79600c5 Compare August 9, 2023 20:59
@NotJeremyLiu NotJeremyLiu requested a review from zrbecker August 9, 2023 21:05
@NotJeremyLiu NotJeremyLiu merged commit 7db25b9 into main Aug 9, 2023
@NotJeremyLiu NotJeremyLiu deleted the jl/place-fee-swap-in-ibc-transfer-action-variant branch August 9, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface-breaking changes that break the user-facing interface to call the contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants