Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Restructure Repo To Make Launching Adapter Contracts Easier #65

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

NotJeremyLiu
Copy link
Member

@NotJeremyLiu NotJeremyLiu commented Aug 9, 2023

Background

  • Previously, the contracts folder was separated by network, which ends up being not ideal since some adapter contracts (for example, astroport swap adapter) can be launched on multiple chains.
  • Thus, chain separation should happen at the deployment level, and not the contract organization level

This PR:

  • Groups the adapter contracts by adapter type, leaving the network organization to the deployment scripts
  • Resulting in a restructure of the repo from:
│
├── contracts/              <- Contains all contracts
│   ├── entry-point/        <- Contains source code and tests for entry point contract
│   └── networks/           <- Contains source code and tests for all network adapter contracts
│       ├── neutron/
│       │   ├── ibc-transfer/
│       │   └── swap/
│       └── osmosis/
│           ├── ibc-transfer/
│           └── swap/

to:

│
├── contracts/              <- Contains all contracts
│   ├── entry-point/        <- Contains source code and tests for entry point contract
│   └── adapters/           <- Contains source code and tests for all network adapter contracts
│       ├── ibc/
│       │   ├── ibc-hooks/
│       │   └── neutron-transfer/
│       └── swap/
│           ├── astroport/
│           └── osmosis-poolmanager/

@NotJeremyLiu NotJeremyLiu changed the title Restructure Repo To Make Launching Adapter Contracts Easier ♻️ Restructure Repo To Make Launching Adapter Contracts Easier Aug 9, 2023
@NotJeremyLiu NotJeremyLiu requested a review from wllmshao August 9, 2023 20:46
@NotJeremyLiu NotJeremyLiu merged commit 0bd9593 into main Aug 9, 2023
@NotJeremyLiu NotJeremyLiu deleted the jl/restructure-adapter-contracts-in-repo branch August 9, 2023 20:59
@NotJeremyLiu NotJeremyLiu mentioned this pull request Sep 12, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant