Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/theming #725

Merged
merged 13 commits into from
Oct 10, 2020
Merged

Features/theming #725

merged 13 commits into from
Oct 10, 2020

Conversation

ioxFR
Copy link
Contributor

@ioxFR ioxFR commented Oct 6, 2020

Hi,

i purpose new feature, ability to switch between some themes from settings defined in appsettings.json.
This will be implemented for admin and sts UI.

Themes implemented are visible here:
https://bootswatch.com/

I would like to integrate all of this themes and keep the current one as default if the appsettings.json value is empty.
Otherwise it will apply the mentionned theme if it exist.

If you got some other ideas/suggest...

  • Integration of bootswatch themes
  • Integration of new configuration value for theme
  • System to apply theme configured
  • Apply same stuff for Admin project
  • Documentation
  • Testing

Enjoy!

@skoruba
Copy link
Owner

skoruba commented Oct 6, 2020

This is cool 👍🏼

@ioxFR ioxFR marked this pull request as ready for review October 7, 2020 05:49
@skoruba
Copy link
Owner

skoruba commented Oct 10, 2020

@ioxFR - could you please resolve the conflicts which were made after merging the CSP feature? 👍
Thanks!

@ioxFR
Copy link
Contributor Author

ioxFR commented Oct 10, 2020

@skoruba done :)

@skoruba skoruba changed the base branch from dev to feature/theming October 10, 2020 22:36
@skoruba skoruba merged commit 7e66ecd into skoruba:feature/theming Oct 10, 2020
@skoruba
Copy link
Owner

skoruba commented Oct 12, 2020

Thanks for you PR, I merged this into feature branch, because it is necesarry to polish it. I noticed that some items are not correctly re-designed after application of any theme and menu on the top is visible incorrectly. I will fix it, they are minnor fixes, you did great work, thanks. 👍

@skoruba skoruba mentioned this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants