Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2020-0071: Potential segfault in the time crate #121

Open
github-actions bot opened this issue Oct 20, 2021 · 6 comments
Open

RUSTSEC-2020-0071: Potential segfault in the time crate #121

github-actions bot opened this issue Oct 20, 2021 · 6 comments

Comments

@github-actions
Copy link

Potential segfault in the time crate

Details
Package time
Version 0.1.43
URL time-rs/time#293
Date 2020-11-18
Patched versions >=0.2.23
Unaffected versions =0.2.0,=0.2.1,=0.2.2,=0.2.3,=0.2.4,=0.2.5,=0.2.6

Impact

Unix-like operating systems may segfault due to dereferencing a dangling pointer in specific circumstances. This requires an environment variable to be set in a different thread than the affected functions. This may occur without the user's knowledge, notably in a third-party library.

The affected functions from time 0.2.7 through 0.2.22 are:

  • time::UtcOffset::local_offset_at
  • time::UtcOffset::try_local_offset_at
  • time::UtcOffset::current_local_offset
  • time::UtcOffset::try_current_local_offset
  • time::OffsetDateTime::now_local
  • time::OffsetDateTime::try_now_local

The affected functions in time 0.1 (all versions) are:

  • at
  • at_utc
  • now

Non-Unix targets (including Windows and wasm) are unaffected.

Patches

Pending a proper fix, the internal method that determines the local offset has been modified to always return None on the affected operating systems. This has the effect of returning an Err on the try_* methods and UTC on the non-try_* methods.

Users and library authors with time in their dependency tree should perform cargo update, which will pull in the updated, unaffected code.

Users of time 0.1 do not have a patch and should upgrade to an unaffected version: time 0.2.23 or greater or the 0.3 series.

Workarounds

No workarounds are known.

References

time-rs/time#293

See advisory page for additional details.

@sksat
Copy link
Owner

sksat commented Oct 20, 2021

time v0.1.43を使ってるのはchrono v0.4.19(をcloudflareが使ってる)

@sksat
Copy link
Owner

sksat commented Oct 20, 2021

chrono v0.4.19は最新かあ

@sksat
Copy link
Owner

sksat commented Oct 20, 2021

  • Bump time to 0.3 chronotope/chrono#578
    これがマージされるのを待つしかないかなあ.でもこの人chronoにtimeを0.2に上げるMRも送ってるけどそれもマージされてないし時間かかるかもしれんな.

@sksat
Copy link
Owner

sksat commented Oct 20, 2021

MR読んできた.
なるほどchronoはRust 1.13とかでも動いてほしいという気持ち(現状明示はされていない)があって,そこらへんtimeと合ってるわけでもないしどうするとなっている.

で,この機会にMSRV(Minimum Supported Rust Version)をちゃんとするか〜という話になりそうな気配がある.これは6ヶ月でいいのでは?ともなっている

@sksat
Copy link
Owner

sksat commented Oct 20, 2021

rustyhorde/vergen@dc2430f
そうか?まあそうかもしれんな

@sksat
Copy link
Owner

sksat commented Jan 24, 2022

chronoくん息してるかこれ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant