[VanFlow]: Include a "version" configuration field for site records

[c-kruse]

The control plane and console presently rely on a version string set on the SITE vanflow records to communicate skupper controller versions of connected sites (distinct from router version.)

Could we add a configuration option so that the "controller" (in this case the non-kube bootstrap process) could expose its version?

This was likely missed on the first go-around as the vanflow spec was missing this attribute: skupperproject/vanflow-specification@260504a

[ssorj]

I'm thinking the router should take a --site site.json argument. For now that file would be:

{
  "version": "9.9.9"
}

But in future, if there's anything else we want in the vanflow site record, we could inject it here. For example, SiteRecord currently has Provider and Namespace, which we could also set. I guess that raises a question: how is the SiteRecord.Name currently determined?

[c-kruse]

@ssorj catching you up.

As of pretty recently we added configuration for this in the regular body of router config. #1543 https://github.com/skupperproject/skupper-router/blob/main/python/skupper_router/management/skrouter.json#L637-L666 and just missed a version property - probably because the field was missing from vanflow spec documentation.

In the nonkube bootstrap we set site name to match the site record name: https://github.com/skupperproject/skupper/blob/v2/pkg/nonkube/api/site_state.go#L271-L276