Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove downgrade of the python version in GHA configuration #102

Closed
kgiusti opened this issue Feb 24, 2022 · 2 comments · May be fixed by #398
Closed

Remove downgrade of the python version in GHA configuration #102

kgiusti opened this issue Feb 24, 2022 · 2 comments · May be fixed by #398

Comments

@kgiusti
Copy link
Contributor

kgiusti commented Feb 24, 2022

Use the default system version of python instead.

Need to remove this step from the workflow configuration.

@jiridanek
Copy link
Contributor

jiridanek commented Feb 25, 2022

Python 3.6 is the default Python on CentOS 8 as well, so although it is a carryover from Qpid Dispatch, it is still reasonable for skupper-router to test with Python 3.6 as much as possible, because there is a good chance it will be deployed on Python 3.6.

Having said that, CentOS/RHEL 8 offers multiple versions of some packages, and Python is one of those.

$ podman run --rm -it ubi8/ubi dnf search 'python3*-devel'
python36-devel.x86_64 : Libraries and header files needed for Python development
python38-devel.x86_64 : Libraries and header files needed for Python development
python39-devel.x86_64 : Libraries and header files needed for Python development

Therefore, it would be possible to pick one of the newer Pythons as the required minimum, if there was a good reason. I can think of, in order of importance

  1. simply restricting the set of possibilities where there is a little to no benefit of keeping all options open (the logic behind my The unbearable optionality of dependencies and features #48)
  2. https://www.python.org/dev/peps/pep-0563/ useful feature for tidier type annotations
  3. asyncio had some api changes since 3.6, so if that is ever used in testing, it is better to support only recent pythons

@kgiusti
Copy link
Contributor Author

kgiusti commented Apr 6, 2022

Good point re: Centos8, closing.

@kgiusti kgiusti closed this as completed Apr 6, 2022
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Dec 6, 2023
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Dec 6, 2023
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Dec 6, 2023
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Dec 6, 2023
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Dec 6, 2023
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Dec 6, 2023
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Dec 6, 2023
jiridanek added a commit to jiridanek/skupper-router that referenced this issue Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants