Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapshotDirectory annotation on test method not taken into account #61

Closed
skuzzle opened this issue Jan 30, 2023 · 1 comment
Closed
Labels
bug Something isn't working component: core
Milestone

Comments

@skuzzle
Copy link
Owner

skuzzle commented Jan 30, 2023

Turns out that, as by the current implementation, the annotation isn't even made to be working on test methods. Making that work severely interfers with orphan detection. I guess its best to only allow the annotation on test class level.

If you want to change the snapshot directory within a single test method, you could use the DSL via snapshot.in(Path.of(...))...

Thus wie should update the documentation accordingly and consequently remove ElementType.METHOD from the annotation's @Target

@skuzzle
Copy link
Owner Author

skuzzle commented Feb 21, 2023

Will be adjusted in 1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: core
Projects
None yet
Development

No branches or pull requests

1 participant