Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's not possible to install with go install #77

Closed
jsravn opened this issue Jan 21, 2022 · 1 comment · Fixed by #79
Closed

It's not possible to install with go install #77

jsravn opened this issue Jan 21, 2022 · 1 comment · Fixed by #79

Comments

@jsravn
Copy link
Contributor

jsravn commented Jan 21, 2022

❯ go install github.com/sky-uk/osprey@v2.7.0
go install: github.com/sky-uk/osprey@v2.7.0: github.com/sky-uk/osprey@v2.7.0: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

And go install of @latest picks up the old v1.5.0 version, which panics when running.

go install github.com/sky-uk/osprey@latest
go: downloading github.com/sky-uk/osprey v1.5.0
...
osprey user login
panic: mismatching message name: got pb.LoginResponse, want pb.ConsumeLoginResponse

Also see #45

@saley89
Copy link
Contributor

saley89 commented Jan 21, 2022

Linked draft PR which we think may resolve this issue. Needs additional work to test it out and ensure it is indeed the fix.

Resulted from this doc: https://github.com/golang/go/wiki/Modules#semantic-import-versioning

@saley89 saley89 linked a pull request Feb 18, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants