Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss on Lifecycle.Event.ON_PAUSE #77

Closed
znakeeye opened this issue Jul 14, 2020 · 2 comments
Closed

Dismiss on Lifecycle.Event.ON_PAUSE #77

znakeeye opened this issue Jul 14, 2020 · 2 comments
Assignees
Labels
Released Released already on the latest version. suggestion I have any suggestions for this library.

Comments

@znakeeye
Copy link

Is your feature request related to a problem?

When my lifecycle owner is paused, the tooltip owner is still displayed when resumed. This poses a problem if onResume() itself shows the tooltip - causing multiple clones of my tooltip to be displayed when toggling resumed/paused state.

Describe the solution you'd like:

Not sure if this should be considered a bug or feature request. To me, it makes no sense to show a tooltip when the lifecycle owner is paused. So either automatically dismiss the tooltip when receiving Lifecycle.Event.ON_PAUSE or add a new method:

balloon.setAutoDismissWhenPaused()

Describe alternatives you've considered:

Sure I can keep the balloon as a member variable and dismiss it explicitly in onPause(). It's ugly, and many developers will miss out on this hack.

@skydoves skydoves added the suggestion I have any suggestions for this library. label Jul 19, 2020
@skydoves
Copy link
Owner

Hi, @znakeeye!
Thank you for your suggestion.
setDismissWhenLifecycleOnPause funtionality will be included in the next release.

@skydoves skydoves self-assigned this Jul 19, 2020
@skydoves skydoves added the Release Next This feature will be released on next version label Jul 19, 2020
@skydoves
Copy link
Owner

Hi, @znakeeye.
It is included in the new version 1.2.0.
You can use the below methods together.

.setLifecycleOwner(value: LifecycleOwner)
.setDismissWhenLifecycleOnPause(value: Boolean)

@skydoves skydoves added Released Released already on the latest version. and removed Release Next This feature will be released on next version labels Jul 30, 2020
@skydoves skydoves closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released Released already on the latest version. suggestion I have any suggestions for this library.
Projects
None yet
Development

No branches or pull requests

2 participants