Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second layout does not have the right height #5

Closed
fgnm opened this issue Dec 21, 2019 · 4 comments
Closed

Second layout does not have the right height #5

fgnm opened this issue Dec 21, 2019 · 4 comments
Assignees
Labels
Released This issue is already fixed and released.

Comments

@fgnm
Copy link

fgnm commented Dec 21, 2019

Please complete the following information:

  • Library Version 1.0.3
  • Affected Device(s) Generic device

I'm using this library inside a recyclerview. Each item in the recyclerview can be expanded, but the content of each item can vary, so the height is different for each item. The library seems to calculate the height for each item, however the height is not correct. For each item is always less the the real layout size.

Expected Behavior:

Since the content of each item is dynamic, the library should expose a method that can re mesure the height of the second layout.

@pierrekhouryy
Copy link

I seem to have this problem as well. Second layout if a horizontal scrollview and yet the more items are added to the scrollview the taller the second layout gets. any fix ?

@Imran-ss
Copy link

I am also facing similar issue.
Indeed I am able to reproduce in demo app as well, see the image.
space_in_2nd_layout
I added some random number of second child then expand and collapse few time all items, then extra space has been added in 2nd layout.

@skydoves skydoves self-assigned this Apr 4, 2020
@skydoves skydoves added the Release Next This issue will be released in the next version. label Apr 4, 2020
@skydoves skydoves mentioned this issue Apr 4, 2020
1 task
@skydoves
Copy link
Owner

skydoves commented Apr 4, 2020

Hi, I fixed the measuring function internally, it's released a new version 1.0.5.
If you check working well in a new version, this issue will be closed.
Thank you for your issue :)

@skydoves skydoves added Released This issue is already fixed and released. and removed Release Next This issue will be released in the next version. labels Apr 5, 2020
@Imran-ss
Copy link

Imran-ss commented Apr 7, 2020

Thanks @skydoves the child space issue has fixed.
but after this fix I observe first time render of parent view is very slow.
seems like scroll issue as well.
expand any bottom parent and then try to scroll up, you will notice scroll is not working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released This issue is already fixed and released.
Projects
None yet
Development

No branches or pull requests

4 participants