Allow to search for full method/field signature #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ield signature, not only the name
…ield signature, not only the name
skylot
requested changes
Mar 9, 2020
…ield signature, not only the name
skylot
approved these changes
Mar 10, 2020
|
@jpstotz thanks! Nice feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search for methods/fields currently only allows to search for the method/field name, but not for the type or the method arguments.
I extended the text index so that the search text is identical to the displayed text (just without the HTML formatting). This allows to search for methods with a specific method signature.
Because the
JMethodandJFieldmakeLongString()implementations were returning HTML formatted text I has to introduce the new methods,makeStringHtml()andmakeLongStringHtml()can be used to return a html formatted representation. Therefore the default implementations now only return plain text data. I only neededmakeLongString()/makeLongStringHtml()but for consistency I also applied this scheme tomakeString()/makeStringHtml().