Skip to content
This repository has been archived by the owner on Dec 5, 2017. It is now read-only.

Events #57

Open
bketelsen opened this issue Jun 28, 2012 · 3 comments
Open

Events #57

bketelsen opened this issue Jun 28, 2012 · 3 comments
Milestone

Comments

@bketelsen
Copy link
Member

Create named events based on lifecycle. Request start, complete, etc.

Create interface for event notification.

create implementation for event notification using a pub/sub (topic) message queue.

@dahankzter
Copy link
Contributor

What kind of events are we talking about here? Is the client listening for events regarding a specific service or can services listen to other services lifecycle events?

Request cycle implies some sort of interceptor design and then it could be used to inject custom filters and such. Is the idea that a given client can register custom callbacks (event listeners i guess) or are the service implementor responsible for it?

@bketelsen
Copy link
Member Author

I am not 100% convinced that we need events. The idea is that we might use an event early in the life cycle of a request to fetch data or prepare for a data operation later in the life cycle of the same request. Technically though this could be just another sky net service. So adding events as a concept may be over complicating things. I am happy to entertain discussion on this...

Brian

On Jul 30, 2012, at 6:46 AM, Henrik Johansson reply@reply.github.com wrote:

What kind of events are we talking about here? Is the client listening for events regarding a specific service or can services listen to other services lifecycle events?

Request cycle implies some sort of interceptor design and then it could be used to inject custom filters and such. Is the idea that a given client can register custom callbacks (event listeners i guess) or are the service implementor responsible for it?


Reply to this email directly or view it on GitHub:
https://github.com/bketelsen/skynet/issues/57#issuecomment-7365215

@dahankzter
Copy link
Contributor

This way its getting rather deep into orchestration land which may or may not be good thing. It can clearly complicate things but if the use-case warrants it perhaps its worth it.

I haven't looked into how the other type of functions like stats collection etc monitoring and what not are implemented (arr they yet?) but possibly an interceptor approach could be used for these things and when that is in place the event functionality could come by itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants