Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Make labels work in task.yaml without the requirement for specifying cloud #3965

Closed
Michaelvll opened this issue Sep 20, 2024 · 0 comments · Fixed by #4022
Closed

[UX] Make labels work in task.yaml without the requirement for specifying cloud #3965

Michaelvll opened this issue Sep 20, 2024 · 0 comments · Fixed by #4022
Assignees
@yika-luo
Labels
good first issue Good for newcomers

Comments

@Michaelvll
Copy link
Collaborator

Currently, SkyPilot disallows the following because cloud is not specified:

resources:
  labels:
    abc: test

This does not make sense because we may want the labels to work across clouds. The original reason we have this constraint is because different clouds can have different requirements for the label format.
One proposal is: When cloud is not specified, we just check the labels with all enabled clouds

Version & Commit info:

  • sky -v: PLEASE_FILL_IN
  • sky -c: PLEASE_FILL_IN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yika-luo yika-luo

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UX] Remove requirement to specify cloud in Resources to use labels skypilot-org/skypilot
2 participants
@Michaelvll @yika-luo