fix: inline field bug in Discord embed #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #509 Fix the issue with the bottom field not spanning across three inline fields in the embed. * Update `packages/core/src/components/discord-embed-field/DiscordEmbedField.ts` to set the `inline-index` attribute only when `inline` is true. * Add a check in `packages/core/src/components/discord-embed-field/DiscordEmbedField.ts` to ensure `inline-index` is not set when `inline` is false. * Update the grid column span logic in `packages/core/src/components/discord-embed-fields/DiscordEmbedFields.ts` to correctly span the bottom field across all three columns when `inline` is not set. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/skyra-project/discord-components/issues/509?shareId=XXXX-XXXX-XXXX-XXXX).
favna
force-pushed
the
favna/fix/inline-field-bug
branch
from
be509e0 to
e343800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
Fix the issue with the bottom field not spanning across three inline fields in the embed.