Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quill 1.1.8+ does not react to input properly #1253

Closed
ergo opened this issue Jan 10, 2017 · 8 comments
Closed

Quill 1.1.8+ does not react to input properly #1253

ergo opened this issue Jan 10, 2017 · 8 comments

Comments

@ergo
Copy link

ergo commented Jan 10, 2017

Hello,
I've upgraded qulljs from 1.1.7 to 1.1.9 and input handling seems to be somewhat broken.

Steps for Reproduction

  1. Write some text, press enter
  2. Try to write some other text

Expected behavior: Some more letters added to the document
Actual behavior: Nothing is printed, delta is not updated. It "looks" like lost focus, because after clicking the editor one can type again until enter is pressed again. However, it is important to note that arrow keys can control caret just fine and enter keypress inserts newline - user just can't type the text. The problem only occurs on firefox, chromium behavior is correct.

Platforms: Linux Ubuntu 16.04, Firefox 50.1.0

Version: versions 1.1.8+ are affected

Version 1.1.7 works fine on both browsers I tested.

@benbro
Copy link
Contributor

benbro commented Jan 10, 2017

I can't reproduce. Works fine for me.
Do you see the issue in the codepen example?

@ergo
Copy link
Author

ergo commented Jan 10, 2017

No, I can't reproduce it in the codepen either, happens in my application though - I'll try to provide a test case, I'm not sure what's causing it yet.

Something must be different between versions since 1.1.7 works fine for me.

@cutteroid
Copy link

cutteroid commented Jan 11, 2017

I'm getting some kind of this issue too but with backspace/delete. An actual behavior is same - editor is focused (caret blinks) but no response on character keys until user clicks editor body.

Its reproducible for me on playground in Firefox on Windows and OSX:

  1. select all editor content (some formatted content should be present in editor)
  2. hit backspace or delete
  3. try to type something
  4. notice that nothing is printed

@ergo
Copy link
Author

ergo commented Jan 11, 2017

Yup, I can replicate this too, what I'm seeing in my application looks the same, except happens also on enter.

@rikh42
Copy link

rikh42 commented Jan 11, 2017

Do you have any custom key bindings?

@ergo
Copy link
Author

ergo commented Jan 11, 2017

Not that I recall.

@jhchen
Copy link
Member

jhchen commented Jan 21, 2017

This looks like a duplicate of #1254. Following @cutteroid 's instructions on the most recent 1.2.0 does not exhibit this bug.

@jhchen jhchen closed this as completed Jan 21, 2017
@ergo
Copy link
Author

ergo commented Jan 21, 2017

Confirmed, looks like 1.2.0 fixes this. Thank you for all the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants