Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include built distribution #144

Closed
bryanaka opened this issue Jun 13, 2014 · 6 comments
Closed

include built distribution #144

bryanaka opened this issue Jun 13, 2014 · 6 comments

Comments

@bryanaka
Copy link

When I bower install quill I expect a built version of quill to be installed. However, looks like you have to go in and build with bowserify first. Would you be willing to include a prebuild version for those of us who do not what to use bowersify?

@jhchen
Copy link
Member

jhchen commented Jun 14, 2014

I'm not willing to add compiled code into source control. It's one of the worst anti-patterns and imposes a high tax on development. But somehow jquery is able to give bower built code without adding it to git. Google seems to think this isn't possible but jquery is clearly doing this somehow. If anyone has any helpful pointers that would be very helpful.

@rafales
Copy link

rafales commented Jun 15, 2014

They include distribution files in commits tagged with a version, for example: https://github.com/jquery/jquery/tree/2.1.0/dist

This sucks though. Maybe having a separate repo for this would be a good idea.

@dominicfrost
Copy link

Yeah, it would be worth considering only compiling the file in tagged releases. That is not to much more cumbersome for the development process. @bryanaka has a point, when bower installing the project, I expect to be able to use the library right away by just requiring in the prebuilt file (As this is how all other bower packages work).

@jhchen
Copy link
Member

jhchen commented Jun 19, 2014

Yes I think what jquery does is an acceptable compromise. That's probably what we'll do.

@bryanaka
Copy link
Author

I think that is fair, thanks 👍

@jhchen
Copy link
Member

jhchen commented Jun 24, 2014

The latest release (v0.15.0) includes the built files for bower now and we'll do this for future releases as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants