-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include built distribution #144
Comments
I'm not willing to add compiled code into source control. It's one of the worst anti-patterns and imposes a high tax on development. But somehow jquery is able to give bower built code without adding it to git. Google seems to think this isn't possible but jquery is clearly doing this somehow. If anyone has any helpful pointers that would be very helpful. |
They include distribution files in commits tagged with a version, for example: https://github.com/jquery/jquery/tree/2.1.0/dist This sucks though. Maybe having a separate repo for this would be a good idea. |
Yeah, it would be worth considering only compiling the file in tagged releases. That is not to much more cumbersome for the development process. @bryanaka has a point, when bower installing the project, I expect to be able to use the library right away by just requiring in the prebuilt file (As this is how all other bower packages work). |
Yes I think what jquery does is an acceptable compromise. That's probably what we'll do. |
I think that is fair, thanks 👍 |
The latest release (v0.15.0) includes the built files for bower now and we'll do this for future releases as well. |
When I
bower install quill
I expect a built version of quill to be installed. However, looks like you have to go in and build with bowserify first. Would you be willing to include a prebuild version for those of us who do not what to use bowersify?The text was updated successfully, but these errors were encountered: