Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar buttons don't have focus styles #1540

Closed
ralrom opened this issue Jun 23, 2017 · 0 comments
Closed

Toolbar buttons don't have focus styles #1540

ralrom opened this issue Jun 23, 2017 · 0 comments

Comments

@ralrom
Copy link

ralrom commented Jun 23, 2017

Buttons in the toolbar have no visual indication that they are focused when going through them via the tab key.

They have the button:hover but are missing the button:focus selector in base.styl:

  button:hover, button.ql-active,
  .ql-picker-label:hover, .ql-picker-label.ql-active,
  .ql-picker-item:hover, .ql-picker-item.ql-selected
    color: activeColor
    .ql-fill, .ql-stroke.ql-fill
      fill: activeColor
    .ql-stroke, .ql-stroke-miter
      stroke: activeColor

Steps for Reproduction

  1. Visit https://quilljs.com/standalone/snow
  2. Tab several times

Expected behavior:

The active toolbar button is blue

Actual behavior:

The active toolbar button remains black

Platforms:

Chrome 58 on macOs 10.12

Version:

1.2.6

@ralrom ralrom changed the title Toolbar buttons missing focus styles Toolbar buttons don't have focus styles Jun 23, 2017
@jhchen jhchen closed this as completed in 84a4212 Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant