Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.1: ql-embed-selected isn't removed when the keyboard is used to change cursor position #1633

Closed
eamodio opened this issue Aug 7, 2017 · 0 comments

Comments

@eamodio
Copy link

eamodio commented Aug 7, 2017

Steps for Reproduction

  1. Visit the playground on quill.com
  2. Add some text, press enter, add an image
  3. Click on the image
  4. Use the arrow keys to change cursor position (which unselects the image as expected)
  5. 🐛 Observe that while the selection is removed, the ql-embed-selected class is left behind -- this doesn't happen if you change the cursor position with the mouse

Expected behavior:

ql-embed-selected is removed

Actual behavior:

ql-embed-selected is left behind

Platforms:

Chrome: Version 60.0.3112.78 (Official Build) (64-bit)
Windows 10 Creators Update

Version:

1.3.1

@jhchen jhchen closed this as completed in c7a05cb Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant