Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet point size doesn't change with the font size #2856

Closed
cxn-pkovacs opened this issue Dec 1, 2019 · 7 comments
Closed

Bullet point size doesn't change with the font size #2856

cxn-pkovacs opened this issue Dec 1, 2019 · 7 comments

Comments

@cxn-pkovacs
Copy link

cxn-pkovacs commented Dec 1, 2019

Steps for Reproduction

  1. Visit https://quilljs.com/playground/ .
  2. Add the following items to modules.toolbar in the JS:
      [{ 'list': 'ordered'}, { 'list': 'bullet' }],
      [{ 'size': ['small', false, 'large', 'huge'] }],

.
3. Wait for the toolbar to be updated with the two items just added.
4. Create text content as a bullet-pointed list with three items.
5. Select the entire text and change the font size to Small, Normal, Large and Huge
6. Observe the size of the bullet-points each time after you changed the font size.

Expected behavior:
The size of the bullet-points increases as the font size is increased and vice versa.

Actual behavior:
The size of the bullet-points remains the same (small) no matter how large the fonts are.

Platforms:

  • Google Chrome Version 78.0.3904.108 (Official Build) (64-bit) - macOS 10.15.1 (19B88)
  • Firefox Browser 70.0.1 (64-bit) - macOS 10.15.1 (19B88)

Version:
1.3.6

@cxn-pkovacs
Copy link
Author

cxn-pkovacs commented Dec 6, 2019

Limiting the solution to list-items having their entire text content uniformly sized (similarly to how text objects in Google Draw behave in this respect) significantly decreases the implementation's complexity -- in principle:

When the user applies the size-styling to the entire text, the old size-style(s) can be removed from the text level and the new style can be applied at the list-item level.

@ghost
Copy link

ghost commented Mar 24, 2020

Do we have the solution yet?

@cxn-pkovacs
Copy link
Author

With current releases, I could solve the issue to some extent (not perfectly) by registering a modified ListItem blot.
In the 2.0 branch, the structure of Lists has been modified so as to allow a much more satisfactory solution. (Alas, the last commit in the 2.0 branch was made some time in 2018 which makes me think, it will never be released.)

@b-solution
Copy link

Hi there, @cxn-pkovacs @simon-ouyang. I am at-last also stuck on the same problem in 2022. Will you please guide me how to get out of this bug.

@ezBeanie
Copy link

ezBeanie commented Dec 9, 2022

Approaching 2023, anyone has a solution to this issue?

@haykkh
Copy link

haykkh commented Mar 29, 2023

We implemented a(n ugly) fix for this which you can see in #409 (comment)

@quill-bot
Copy link

Quill 2.0 has been released (announcement post) with many changes and fixes. If this is still an issue please create a new issue after reviewing our updated Contributing guide 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants