Replace cursor_pagination

[dblock]

https://github.com/Kukunin/cursor_pagination will no longer be maintained. I've maintained a fork, but it doesn't make sense long term, https://github.com/slack-ruby/slack-ruby-bot-server/blob/master/Gemfile#L12.

Replace it with another option, e.g. https://github.com/ddnexus/pagy.

[crazyoptimist]

Let me take this one.

[crazyoptimist]

Stuck in #155

[crazyoptimist]

This is my environment setup:

debian @ workspace in slack-ruby-bot-server on  chore/replace-cursor-with-pagy via 💎 v3.1.3 on ☁️  (us-east-2)
⌛ 11:46 ❯ firefox --version
Mozilla Firefox 108.0.1

debian @ workspace in slack-ruby-bot-server on  chore/replace-cursor-with-pagy via 💎 v3.1.3 on ☁️  (us-east-2)
⌛ 11:46 ❯ geckodriver --version
geckodriver 0.32.0 (4563dd583110 2022-10-13 09:22 +0000)

And the integration tests still fail:

  1) Teams oauth v1 oauth registers a team
     Failure/Error: visit '/?v1&code=code'

     Selenium::WebDriver::Error::UnknownError:
       Process unexpectedly closed with status 1
     # ./spec/integration/teams_spec.rb:26:in `block (5 levels) in <top (required)>'
     # ./spec/integration/teams_spec.rb:25:in `block (4 levels) in <top (required)>'
     # ./spec/support/database_cleaner.rb:11:in `block (3 levels) in <top (required)>'
     # ./spec/support/database_cleaner.rb:10:in `block (2 levels) in <top (required)>'

Meanwhile, using this command, all tests pass:
/usr/bin/xvfb-run --auto-servernum bundle exec rake spec

Do you have any advice, @dblock ?

[dblock]

Is this Linux? I think you may need to start Xvfb manually to get a display. This seems to have a reasonable explanation: http://elementalselenium.com/tips/38-headless

[crazyoptimist]

I've been playing around replacing cursor with pagy. pagy doesn't support cursor pagination. Are we okay to drop the cursor pagination support for active record?
@dblock

[dblock]

@crazyoptimist I don't think so unless we absolutely must, because cursor pagination is the only way to keep a stable query. I wouldn't use a page by page sort in a production app with changing data.

[crazyoptimist]

@dblock pagy-cursor seems to be only one supporting cursor pagination for AR, but I wouldn't recommend to use it because it's immuture yet.

[dblock]

@dblock pagy-cursor seems to be only one supporting cursor pagination for AR, but I wouldn't recommend to use it because it's immuture yet.

I like it enough, let's help mature it?

[crazyoptimist]

Already tried it and got this issue, I might did something wrong. Nonetheless, the repo doesn't seem to be actively maintained, no responses in several open issues.

[dblock]

Do you have a branch with this non-working code?

[crazyoptimist]

https://github.com/crazyoptimist/slack-ruby-bot-server/tree/chore/replace-cursor-with-pagy

Nothing to commit yet.

[crazyoptimist]

I'm playing with this starter, where slack-ruby-bot-server is locally plugged in. Just FYI.