Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for multiple concurrency libraries #338

Closed
dblock opened this issue Aug 5, 2020 · 1 comment · Fixed by #357
Closed

Remove support for multiple concurrency libraries #338

dblock opened this issue Aug 5, 2020 · 1 comment · Fixed by #357
Labels
chore

Comments

@dblock
Copy link
Collaborator

dblock commented Aug 5, 2020

I suspect nobody uses celluloid anymore and we have a broken implementation with faye-websocket, #285, so nobody uses that either. Cut down on maintenance and remove those when upgrading to #282.
@dblock dblock added the chore label Aug 5, 2020
@dblock dblock mentioned this issue Sep 19, 2020
Closed
@wasabigeek wasabigeek mentioned this issue Jan 9, 2021
Merged
@dblock
Copy link
Collaborator Author

dblock commented Jan 20, 2021

@wasabigeek want to remove faye the same way? We should still leave concurrency optional because not everybody needs RTM, so the doc should just say that.

@wasabigeek wasabigeek mentioned this issue Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove faye wasabigeek/slack-ruby-client
1 participant
@dblock