Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in middleware should gracefully handle messages without text property #182

Closed
4 of 9 tasks
shaydewael opened this issue May 6, 2019 · 0 comments · Fixed by #195
Closed
4 of 9 tasks

Built-in middleware should gracefully handle messages without text property #182

shaydewael opened this issue May 6, 2019 · 0 comments · Fixed by #195
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@shaydewael
Copy link
Contributor

Description

Currently there is a bug where builtin middleware is failing when messages are received that don't have the text property. Optional text became possible with Block Kit messages. The code that threw this was in matchMessage() though there may be more occurrences of the framework relying on a text value: https://github.com/slackapi/bolt/blob/master/src/middleware/builtin.ts#L160

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added the bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented label May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants