Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/node should not be set to an exact version in dependencies #1867

Closed
adapptor-kurt opened this issue Jun 12, 2023 · 1 comment · Fixed by #1894
Closed

@types/node should not be set to an exact version in dependencies #1867

adapptor-kurt opened this issue Jun 12, 2023 · 1 comment · Fixed by #1894
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch
Milestone

Comments

@adapptor-kurt
Copy link

The @slack/bolt package specifies an exact version of @types/node in it's dependencies list, rather than devDependencies. This pollutes the types of any project that uses it, because they are very unlikely to have that exact version too, and may run an entirely different version of Node and require different types.

Reproducible in:

The Slack SDK version

@slack/bolt >=3.12.2

Node.js runtime version

All versions

Steps to reproduce:

Add @slack/bolt >=3.12.2 to any project

Expected result:

@slack/bolt should not have @types/node in the dependencies list unless Node.js types are referenced in the public interface. If it does require @types/node then it should permit all versions that @slack/bolt supports, without specifying an exact version.

Actual result:

@slack/bolt forces the install of "@types/node" v18 or above in the project.

Requirements

See above

@srajiang srajiang added this to the 3.13.2 milestone Jun 13, 2023
@srajiang
Copy link
Member

Hi @adapptor-kurt - I'm inclined to agree. I'll add this to our upcoming release milestone as something we want to get updated. Thanks for writing in!

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch and removed untriaged labels Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants