Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnvelopedEvent is no longer exported with v3.21.2 #2243

Closed
nekoya opened this issue Sep 11, 2024 · 4 comments · Fixed by #2245
Closed

EnvelopedEvent is no longer exported with v3.21.2 #2243

nekoya opened this issue Sep 11, 2024 · 4 comments · Fixed by #2245
Assignees
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch TypeScript-specific
Milestone

Comments

@nekoya
Copy link

nekoya commented Sep 11, 2024

@slack/bolt version

3.21.2

Your App and Receiver Configuration

import { type EnvelopedEvent } from '@slack/bolt';

const parseEventJson = (body: string) => {
  const slackEvent: EnvelopedEvent = JSON.parse(body);
};

Node.js runtime version

v20.10.0

Steps to reproduce:

  1. My application works fine with @slack/bolt 3.21.1
  2. Upgrade @slack/bolt to 3.21.2
  3. tsc throws the following error: error TS2305: Module '"@slack/bolt"' has no exported member 'EnvelopedEvent'.

Expected result:

Backward compatibility should be maintained, and EnvelopedEvent should be importable.

Additionally, EnvelopedEvent was explicitly exported in #1334.

Actual result:

EnvelopedEvent is not exported at 3.21.2.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch TypeScript-specific and removed untriaged labels Sep 11, 2024
@seratch seratch added this to the 3.21.3 milestone Sep 11, 2024
@seratch seratch changed the title Where is EnvelopedEvent in 3.21.2? EnvelopedEvent is no longer exported with v3.21.2 Sep 11, 2024
@seratch
Copy link
Member

seratch commented Sep 11, 2024

Hi @nekoya, thank you so much for reporting this issue, and we're sorry for the disruption by a patch release.

I have identified the PR that introduced this change: https://github.com/slackapi/bolt-js/pull/2223/files#r1753234778. Other members of my team will look into this issue later during North American timezone hours and will likely release a patch to resolve it.

@filmaj
Copy link
Contributor

filmaj commented Sep 11, 2024

My apologies, that was my mistake. I will cut a patch release to fix.

@nekoya
Copy link
Author

nekoya commented Sep 11, 2024

Thank you for the quick response, I'm really grateful!

@filmaj
Copy link
Contributor

filmaj commented Sep 11, 2024

bolt v3.21.3 is live and should address this issue. Once again, my sincere apologies for the disruption 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch TypeScript-specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants