Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove matchCallbackId() #266

Closed
3 tasks done
aoberoi opened this issue Sep 28, 2019 · 0 comments
Closed
3 tasks done

Remove matchCallbackId() #266

aoberoi opened this issue Sep 28, 2019 · 0 comments
Labels
enhancement M-T: A feature request for new functionality

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Sep 28, 2019

Description

The matchCallbackId() function (in src/middleware/builtin.ts) contains significant code duplication as compared to matchConstraints().

We can potentially replace the call sites matchCallbackId(callback_id) with matchConstraints({ callback_id: callbackId }).

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added the enhancement M-T: A feature request for new functionality label Sep 28, 2019
@shaydewael shaydewael mentioned this issue Oct 3, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aoberoi @shaydewael