Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to constrain actions by type #325

Closed
4 of 9 tasks
selfcontained opened this issue Dec 4, 2019 · 2 comments
Closed
4 of 9 tasks

Add the ability to constrain actions by type #325

selfcontained opened this issue Dec 4, 2019 · 2 comments
Labels
enhancement M-T: A feature request for new functionality

Comments

@selfcontained
Copy link
Contributor

Description

It would be helpful to have the ability to constrain actions by type as well as the other existing constraint properties. This would allow slightly more flexibility for routing specific types of actions to certain handlers. Being able to constrain by type allows you to route actions that may have different types but the same callback_id (or other constraint properties), or even route all actions of a specific type to one handler (regardless of callback_id, action_id or block_id. Sharing things like a callback_id across different action types sounds weird at first, but I've bumped into some places where this would be useful.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@shaydewael shaydewael added the enhancement M-T: A feature request for new functionality label Dec 4, 2019
@stevengill
Copy link
Member

This makes sense to me. I've definitely had to reuse an actionID on multiple actions even though our docs say it should be unique.

Not sure what if any unattended consequences could arise from offering more contraint options.

@stevengill
Copy link
Member

PR has been merged. Closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

No branches or pull requests

3 participants