-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🍽 Downstream apps can't reliably test async listeners #338
Comments
Thanks for the issue and PR @tteltrab. I'll bring this to the attention of a colleague. |
@aoberoi Any chance you can check this one out when you have some spare cycles? |
Left a comment in the PR linked above which outlines some approaches we could use to fix the issue. |
With the release of Bolt for JS v2, you can now test listeners more reliably. We've demonstrated a pattern for this in Bolt's own tests, using the |
Description
Trying to manage testing of a bolt app and running into some issues with reliably handling async - request handlers are resolving before messages have been handled. Wrote up a couple of test cases and opened a PR here to show them failing: #337
We have business logic in async handlers (pretty common pattern?) and ideally we'd be able to handle the response when it comes from that async pattern. Example PR shows three failing cases.
What type of issue is this? (place an
x
in one of the[ ]
)Requirements (place an
x
in each of the[ ]
)The text was updated successfully, but these errors were encountered: